[ntuple] Add RNTupleProcessor::RequestField by typename string#22403
Open
enirolf wants to merge 1 commit into
Open
[ntuple] Add RNTupleProcessor::RequestField by typename string#22403enirolf wants to merge 1 commit into
RNTupleProcessor::RequestField by typename string#22403enirolf wants to merge 1 commit into
Conversation
pcanal
reviewed
May 26, 2026
| auto x = proc->RequestField("x", "float"); | ||
|
|
||
| auto yPtr = std::make_shared<std::vector<float>>(); | ||
| auto y = proc->RequestField("y", "std::vector<float>", yPtr.get()); |
Member
There was a problem hiding this comment.
To also test that the normalization steps are properly used consider using (in addition?) a non-normalized spelling (one of std::vector<float >, std::vector<Float_t>, etc.)
jblomer
approved these changes
May 26, 2026
Test Results 22 files 22 suites 3d 13h 43m 15s ⏱️ For more details on these failures, see this check. Results for commit 997ccde. |
enirolf
force-pushed
the
ntuple-proc-request-field-typename
branch
from
997ccde to
4e16836
Compare
enirolf
force-pushed
the
ntuple-proc-request-field-typename
branch
from
4e16836 to
bdcb912
Compare
pcanal
reviewed
May 26, 2026
| } | ||
| { | ||
| auto proc = RNTupleProcessor::Create({fNTupleNames[0], fFileNames[0]}); | ||
| EXPECT_THROW(proc->RequestField("y", "std::vetor<float>"), ROOT::RException); |
Member
There was a problem hiding this comment.
Last one :) ... We should also test the error ("type_that_does_not_exist")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a non-templated overload of
RNTupleProcessor::RequestFieldthat takes a typename string, in case the type is not known at compile time.