[6.40] [df] Lift requirement to provide explicit return type in Vary expression#22077
Open
root-project-bot wants to merge 3 commits intoroot-project:v6-40-00-patchesfrom
Open
[6.40] [df] Lift requirement to provide explicit return type in Vary expression#22077root-project-bot wants to merge 3 commits intoroot-project:v6-40-00-patchesfrom
root-project-bot wants to merge 3 commits intoroot-project:v6-40-00-patchesfrom
Conversation
The expression gets a trailing return type injected of the equivalent necessary RVec type, only in case the user is not already providing it. As long as the expression returns a sequence of characters that is a valid way to instantiate an RVec constructor, the expression will compile.
The condition that triggers the injection of the trailing return type is if the user expression is of type '{...}', which could be a potential candidate constructor for an RVec.
(cherry picked from commit c56ec4e)
(cherry picked from commit 634172f)
(cherry picked from commit 1dc6621)
root-project-bot
requested review from
dpiparo,
martamaja10 and
vepadulano
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22028, requested by @vepadulano.