Introduce GetPadWidth() and GetPadHeight() methods#22072
Open
linev wants to merge 5 commits intoroot-project:masterfrom
Open
Introduce GetPadWidth() and GetPadHeight() methods#22072linev wants to merge 5 commits intoroot-project:masterfrom
linev wants to merge 5 commits intoroot-project:masterfrom
Conversation
It is clear functions to obtain pad dimension - disregard if it is sub-pad or canvas itself.
Text size need to be scaled with pad width or height. So this is first place where new methods can be used
couet
approved these changes
Apr 27, 2026
Test Results 22 files 22 suites 3d 11h 33m 34s ⏱️ For more details on these failures, see this check. Results for commit 583c8e1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a long time
gPad->XtoPixel(gPad->GetX2());andgPad->YtoPixel(gPad->GetY1());were used.This is not very user-friendly.
Instead use canvas width and height multiplied by
GetAbsWNDC()andGetAbsHNDC()respectively.Adjust in several places in source code - especially around text size conversions.