Skip to content

[core] Avoid a clang vectoriser bug in TColorGradient.#22060

Merged
hageboeck merged 3 commits intoroot-project:masterfrom
hageboeck:loop_vectoriser_bug
Apr 27, 2026
Merged

[core] Avoid a clang vectoriser bug in TColorGradient.#22060
hageboeck merged 3 commits intoroot-project:masterfrom
hageboeck:loop_vectoriser_bug

Conversation

@hageboeck
Copy link
Copy Markdown
Member

@hageboeck hageboeck commented Apr 24, 2026

The loop vectoriser in clang-20 to clang-22 can overflow the stack, which should explain the crashes observed when mac beta moved to clang-21.
Here, we instruct the vectoriser to leave the loop in the affected function untouched.

llvm/llvm-project#194008

Fix #21367

@hageboeck hageboeck self-assigned this Apr 24, 2026
The loop vectoriser in clang-20 to clang-22 can overflow the stack,
which should explain the crashes observed when mac beta moved to
clang-21.
Here, we instruct the vectoriser to leave the affected loop untouched.

llvm/llvm-project#194008

Fix root-project#21367
This reverts commit 8c25d31.

With the fix for root-project#21367, the test is expected to pass again.
This reverts commit 70ad2cb.

With the fix for root-project#21367, the tests are expected to pass again.
@hageboeck hageboeck force-pushed the loop_vectoriser_bug branch from 132ce99 to 4f3dcc4 Compare April 27, 2026 09:07
@hageboeck hageboeck linked an issue Apr 27, 2026 that may be closed by this pull request
1 task
@hageboeck hageboeck marked this pull request as ready for review April 27, 2026 09:14
@hageboeck hageboeck changed the title [core] Try going around a suspected clang vectoriser bug. [core] Avoid a clang vectoriser bug in TColorGradient. Apr 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Test Results

    22 files      22 suites   3d 6h 21m 15s ⏱️
 3 851 tests  3 799 ✅ 0 💤 52 ❌
76 047 runs  75 995 ✅ 0 💤 52 ❌

For more details on these failures, see this check.

Results for commit 4f3dcc4.

♻️ This comment has been updated with latest results.

@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Apr 27, 2026

we'll probably need backports until 6.36 for this one.

@hageboeck hageboeck added the clean build Ask CI to do non-incremental build on PR label Apr 27, 2026
@hageboeck hageboeck merged commit d2882b2 into root-project:master Apr 27, 2026
53 of 56 checks passed
@hageboeck hageboeck deleted the loop_vectoriser_bug branch April 27, 2026 15:28
@hageboeck
Copy link
Copy Markdown
Member Author

/backport 6.40 6.38 6.36

@hageboeck
Copy link
Copy Markdown
Member Author

/backport to 6.40 6.38 6.36

@hageboeck
Copy link
Copy Markdown
Member Author

/backport to 6.40

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22060 to branch 6.40 requested by hageboeck

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22078

@hageboeck
Copy link
Copy Markdown
Member Author

/backport to 6.38,6.36

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22060 to branches 6.38 and 6.36 requested by hageboeck

@root-project-bot
Copy link
Copy Markdown

Something went wrong with the creation of the PR to backport to 6.38: @hageboeck please see the logs

@root-project-bot
Copy link
Copy Markdown

Something went wrong with the creation of the PR to backport to 6.36: @hageboeck please see the logs

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stack corruption in TColorGradient on mac beta

3 participants