Skip to content

io: Readd deprecated TBuffer::ReadClass signature.#21789

Merged
pcanal merged 2 commits intoroot-project:Arlesiennefrom
pcanal:Arlesienne_LongRangeLeftOver
Apr 3, 2026
Merged

io: Readd deprecated TBuffer::ReadClass signature.#21789
pcanal merged 2 commits intoroot-project:Arlesiennefrom
pcanal:Arlesienne_LongRangeLeftOver

Conversation

@pcanal
Copy link
Copy Markdown
Member

@pcanal pcanal commented Apr 3, 2026

No description provided.

@pcanal pcanal self-assigned this Apr 3, 2026
@pcanal pcanal requested a review from dpiparo as a code owner April 3, 2026 16:45
@pcanal pcanal requested review from Copilot and removed request for dpiparo April 3, 2026 16:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-introduces the deprecated TBuffer::ReadClass(const TClass*, UInt_t*) API as an inline compatibility wrapper around the existing 64-bit objTag overload, aiming to preserve older call sites while guiding users to the 64-bit signature.

Changes:

  • Re-added the deprecated ReadClass(const TClass*, UInt_t*) overload in TBuffer.
  • Implemented forwarding logic to the ULong64_t* overload with a range check and diagnostic on overflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pcanal pcanal force-pushed the Arlesienne_LongRangeLeftOver branch from cecfbfb to 0b94621 Compare April 3, 2026 17:03
@pcanal pcanal requested a review from Copilot April 3, 2026 17:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pcanal pcanal force-pushed the Arlesienne_LongRangeLeftOver branch from ded1123 to 3397677 Compare April 3, 2026 17:19
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Test Results

    22 files      22 suites   3d 5h 54m 22s ⏱️
 3 836 tests  3 835 ✅  1 💤 0 ❌
75 734 runs  75 716 ✅ 18 💤 0 ❌

Results for commit 3397677.

@pcanal pcanal merged commit e669a81 into root-project:Arlesienne Apr 3, 2026
30 checks passed
@pcanal pcanal deleted the Arlesienne_LongRangeLeftOver branch April 3, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants