io: Readd deprecated TBuffer::ReadClass signature.#21789
Merged
pcanal merged 2 commits intoroot-project:Arlesiennefrom Apr 3, 2026
Merged
io: Readd deprecated TBuffer::ReadClass signature.#21789pcanal merged 2 commits intoroot-project:Arlesiennefrom
pcanal merged 2 commits intoroot-project:Arlesiennefrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR re-introduces the deprecated TBuffer::ReadClass(const TClass*, UInt_t*) API as an inline compatibility wrapper around the existing 64-bit objTag overload, aiming to preserve older call sites while guiding users to the 64-bit signature.
Changes:
- Re-added the deprecated
ReadClass(const TClass*, UInt_t*)overload inTBuffer. - Implemented forwarding logic to the
ULong64_t*overload with a range check and diagnostic on overflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cecfbfb to
0b94621
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ded1123 to
3397677
Compare
Test Results 22 files 22 suites 3d 5h 54m 22s ⏱️ Results for commit 3397677. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.