[v638] Backport recent Python interface fixes#21784
Merged
guitargeek merged 2 commits intoroot-project:v6-38-00-patchesfrom Apr 3, 2026
Merged
[v638] Backport recent Python interface fixes#21784guitargeek merged 2 commits intoroot-project:v6-38-00-patchesfrom
guitargeek merged 2 commits intoroot-project:v6-38-00-patchesfrom
Conversation
A unit test covering the reported issue is also implemented. Closes root-project#21732 (cherry picked from commit de992f1)
Introduce a Python-side adapter (**TDirectoryPythonAdapter**) to implement the expected lazy semantics of gDirectory, analogous to `ROOT::Internal::TDirectoryAtomicAdapter` on the C++ side. In C++, `gDirectory` is defined as a macro expanding to a temporary adapter object that implicitly converts to the current `TDirectory*`. This relies on implicit conversions, operator overloading, preprocessor tricks, and pretending to ROOT meta that the type of `gDirectory` is a functor returning a `TDirectory*` that cannot be faithfully represented in Python bindings. This results in problems like root-project#21693, which shows that the coupling between these hacks and cppyy conversion is very brittle. The new TDirectoryPythonAdapter restores the intended semantics by: * Resolving the current directory lazily on every attribute access * Forwarding attribute access, string representation, truthiness, and equality comparisons to the current TDirectory Note that identity comparisons (`is`) are no longer meaningful for gDirectory, as it represents a dynamic proxy rather than a stable object. Tests are updated to use equality (`==`), matching the C++ adapter semantics, reverting a change that was only made recently. Assignment semantics (`gDirectory = ...`) are intentionally not supported, as Python does not provide a mechanism equivalent to C++ operator= on proxy objects without introducing fragile or intrusive behavior. Closes root-project#21693. A unit test covering the reproducer for that issue is also implemented. (cherry picked from commit 2659fe3)
Test Results 19 files 19 suites 2d 21h 28m 56s ⏱️ Results for commit 0bce91a. |
guitargeek
merged commit 63aae0c
into
root-project:v6-38-00-patches
25 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the following bugfix PRs:
long doublearray executor #21769gDirectoryadapter to restore lazy semantics #21781