[cmake] ASEXTRA_LIBRARIES should not depend on if builtin or not#21763
Merged
linev merged 1 commit intoroot-project:masterfrom Apr 2, 2026
Merged
[cmake] ASEXTRA_LIBRARIES should not depend on if builtin or not#21763linev merged 1 commit intoroot-project:masterfrom
linev merged 1 commit intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 8h 53m 32s ⏱️ For more details on these failures, see this check. Results for commit ef67267. |
linev
approved these changes
Apr 2, 2026
Member
linev
left a comment
linev
left a comment
There was a problem hiding this comment.
Strange that was not done before.
Probably while libAfterImage old Makefile link own components without extra flags.
Now with conversion to cmake this will be required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spinoff of #21649