[6.36] [RF] Fix ownership problems in RooFixedProdPdf#21553
Merged
dpiparo merged 1 commit intoroot-project:v6-36-00-patchesfrom Mar 10, 2026
Merged
[6.36] [RF] Fix ownership problems in RooFixedProdPdf#21553dpiparo merged 1 commit intoroot-project:v6-36-00-patchesfrom
dpiparo merged 1 commit intoroot-project:v6-36-00-patchesfrom
Conversation
This is a followup on 101beeb, where the RooFit objects owned by the `RooProdPdf::CacheElem` are transferred to the `RooFixedProdPdf`. Since there was a data member `CacheElem::_ownedList`, I was misled into thinking that the other collections are non-owning. This is not the case, as the elements of `_numList` and `_denList` are all added with `RooAbsCollection::addOwned()`. So the ownership also has to be transferred from these collections. Finally, the control flow is fixed up such that the ownership transfer is done before an early return, and also the ownership for all objects in the owned collections is transferred unconditionally. That's because some objects are only unconditionally required as dependencies of the top-level RooAbsArgs in the chache element. This fixes a crash when running the reproducer in GitHub issue root-project#16673 with ROOT master. (cherry picked from commit 829309f)
Test Results 18 files 18 suites 2d 16h 6m 58s ⏱️ For more details on these failures, see this check. Results for commit 3d40286. ♻️ This comment has been updated with latest results. |
dpiparo
merged commit 642ac77
into
root-project:v6-36-00-patches
39 of 41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21540, requested by @guitargeek.