[RF] Support ranged chi-square fits#21552
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 10, 2026
Merged
Conversation
Implement a (multi-)range check in `RooChi2Var` to skip bins that are not in the requested fit range. Also add a unit test that checks the resulting test statistics are additive as expected, and behave correctly for the different modes of extended pdf, non-extended pdf, and yield prediction by RooAbsReal. Closes root-project#21541.
guitargeek
changed the title
1 task
dpiparo
approved these changes
Mar 10, 2026
Contributor
Author
|
/backport to 6.36, 6.38 |
|
Something went wrong with the backport to 6.36: @guitargeek please see the logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a (multi-)range check in
RooChi2Varto skip bins that arenot in the requested fit range.
Also add a unit test that checks the resulting test statistics are
additive as expected, and behave correctly for the different modes of
extended pdf, non-extended pdf, and yield prediction by RooAbsReal.
Closes #21541.