[RF] Deprecate removeRange() method#21548
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 10, 2026
Merged
Conversation
The method `RooRealVar::removeRange()` and the corresponding method in `RooErrorVar` have been deprecated because the name was misleading, and they will be removed in ROOT 6.42. Despite the name, the function did not actually remove a range, but only cleared its limits by setting them to `−inf,+inf` leaving the named range itself defined (so `hasRange()` would still return `true`). Users should now explicitly call `removeMin()` and `removeMax()` to remove the lower and upper limits of a range. Internal RooFit code has been updated accordingly. I deliberately didn't introduce an alternative function with a more descriptive name (like `removeMinMax()`), because using that would result in backwards incompatible code, and also removing the range limits it a niche feature. Even our own code doesn't do it much. So I think it's fair to suggest to replace usage with `removeMin()` and `removeMax()`, even if slightly more verbose.
dpiparo
approved these changes
Mar 10, 2026
Test Results 22 files 22 suites 3d 8h 16m 18s ⏱️ Results for commit 210f787. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
RooRealVar::removeRange()and the corresponding method inRooErrorVarhave been deprecated because the name was misleading, and they will be removed in ROOT 6.42. Despite the name, the function did not actually remove a range, but only cleared its limits by setting them to−inf,+infleaving the named range itself defined (sohasRange()would still returntrue). Users should now explicitly callremoveMin()andremoveMax()to remove the lower and upper limits of a range.Internal RooFit code has been updated accordingly.
I deliberately didn't introduce an alternative function with a more descriptive name (like
removeMinMax()), because using that would result in backwards incompatible code, and also removing the range limits it a niche feature. Even our own code doesn't do it much. So I think it's fair to suggest to replace usage withremoveMin()andremoveMax(), even if slightly more verbose.Closes #21542