[main] Rewrite rootmkdir in C++#21521
Open
silverweed wants to merge 3 commits intoroot-project:masterfrom
Open
[main] Rewrite rootmkdir in C++#21521silverweed wants to merge 3 commits intoroot-project:masterfrom
silverweed wants to merge 3 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 4h 57m 27s ⏱️ Results for commit 481d29a. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Mar 6, 2026
Member
vepadulano
left a comment
There was a problem hiding this comment.
Cool thanks! Some minor comments from my side.
808a923 to
dd261be
Compare
pcanal
reviewed
Mar 6, 2026
| FIXTURES_SETUP main-SimpleRootmkdir4-fixture) | ||
|
|
||
| ROOTTEST_ADD_TEST(SimpleRootmkdir4CheckOutput | ||
| COMMAND ${TOOLS_PREFIX}/rootls${exeext} -1 target4.root |
Member
There was a problem hiding this comment.
What is the intent of the test? and/or how does it check for success?
Contributor
Author
There was a problem hiding this comment.
It verifies that calling rootmkdir file.root creates an empty ROOT file (rootls returns 1 if the file does not exist and 0 otherwise)
pcanal
reviewed
Mar 6, 2026
pcanal
reviewed
Mar 6, 2026
dd261be to
481d29a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Replace the python version of rootmkdir with a native one.
Changes or fixes:
I changed one small thing from the original
rootmkdir: calling:when
foo.rootdoes not exist would create the file and the directory in the original, whereas in this version it will error out unless you pass the-pflag. The rationale is that the top-level file should count as a "parent directory", so we should not create it implicitly unless-pis specified. Callingrootmkdir foo.rootworks as before (except it will error out if the file already exists).Checklist: