[tmva][sofie] Don't allocate small constant vectors on the stack#21510
Closed
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Closed
[tmva][sofie] Don't allocate small constant vectors on the stack#21510guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
It simplifies the code a bit if we don't have separate treatment of larger and smaller (n < 100) constant vectors. It's also not that meaningful to have a magic size threshold per vector that also doesn't help avoiding large stack allocations. The mechanism is mute when there are many small constant tensors, so we might as well get rid of it to keep things simple.
Test Results 20 files 20 suites 2d 21h 5m 58s ⏱️ Results for commit b273cbb. |
lmoneta
reviewed
Mar 9, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Is this really needed? I understand the simplification; however, it can be more efficient to have the small tensors allocated on the stack.
Contributor
Author
|
This PR is not strictly necessary, if you prefer to keep it as it is I'm fine too 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It simplifies the code a bit if we don't have separate treatment of larger and smaller (n < 100) constant vectors. It's also not that meaningful to have a magic size threshold per vector that also doesn't help avoiding large stack allocations. The mechanism is mute when there are many small constant tensors, so we might as well get rid of it to keep things simple.