[tmva][sofie] Followup on "Disentangle PyMVA and SOFIE" #20578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disentanglement of PyMVA and SOFIE accidentally moved too many test files. Follows up on 178a9f9, which should have only moved `generatePyTorchModels.py`, but it also moved other files with similar names that are used for PyMVA tests.
Follows up on 178a9f9, where the SOFIE Keras and PyTorch parsers were moved from `tmva/pymva` to `tmva/sofie_parsers` and are now conditional on the `tmva-sofie` and not `tmva-pymva` configuration flag. It was forgotten to update the corresponding configuration checks in the CMakeLists.txt of the tutorials.
There is no need for that, and they are not available if ROOT was built with `tmva-pymva=OFF`.
guitargeek
force-pushed
the
pymva_sofie_followup
branch
from
6fee380 to
7f77fa0
Compare
Test Results 22 files 22 suites 3d 14h 50m 5s ⏱️ Results for commit 99e807d. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
pymva_sofie_followup
branch
3 times, most recently
from
99e807d to
64e70e5
Compare
vepadulano
approved these changes
Dec 1, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM, consider running ruff and add the results as a separate commit.
guitargeek
force-pushed
the
pymva_sofie_followup
branch
3 times, most recently
from
a33ba34 to
7da0e43
Compare
The same was already done for the Keras unit tests when PyMVA and SOFIE were disentangled, but the same thing also has to be done for the tutorials.
guitargeek
force-pushed
the
pymva_sofie_followup
branch
from
7da0e43 to
76b0ed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[tmva][sofie] Followup on "Disentangle PyMVA and SOFIE" (#20355) by moving back some files that should not have been moved, and updating the tutorial vetoes.