-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Geom] Add auxiliary user-data export in TGDMLWrite #20358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I reformatted my commit (clang), do I still have to do so something to start the tests again? |
|
Is there a way in which we could test this fix? |
|
I described two ways in the issues (Reproducer). |
|
I am not sure why the ruff code analysis fails for files I haven't changed |
agheata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KoljaFrahm for this addition - reading the auxiliary data via TGDMLParse was only intended so far to provide user access to these data via the volume user extensions, but it is indeed nice to be able to re-export it. See my comment requesting a small correction - otherwise your patch works nicely!
Actually, this is not a fix but a feature, allowing the re-export of GDML auxiliary volume data imported from a GDML file. It could be tested eventually if we make a more general GDML import/export regression test |
This adds the option of exporting auxiliary of TGeoVolumes in TGDMLWrite Fixes root-project#20356
|
Adjusted and rebased :) |
|
Is still something missing from my side? Would be nice to have this in the next root version :) |
|
I propose to have these changes integrated in the main branch as soon as the tests passes. |
|
That would be great! |
Test Results 22 files 22 suites 3d 20h 27m 42s ⏱️ For more details on these failures, see this check. Results for commit 30ef55c. |
This Pull request:
Adds the option of exporting auxiliary of TGeoVolumes in TGDMLWrite
Uses same format as in https://github.com/root-project/root/blob/master/geom/gdml/src/TGDMLParse.cxx
Changes or fixes:
Fixes #20356
Checklist:
This PR fixes #20356