Skip to content

Fixed RT120946#1

Open
nigelhorne wants to merge 3 commits intoronsavage:masterfrom
nigelhorne:master
Open

Fixed RT120946#1
nigelhorne wants to merge 3 commits intoronsavage:masterfrom
nigelhorne:master

Conversation

@nigelhorne
Copy link
Copy Markdown

The main fix is the removal of 'my' for a variable already defined in the same scope. The other fixes are around the Makefile.PL which didn't work.

@ronsavage
Copy link
Copy Markdown
Owner

I've uncovered a can of worms. My source version is 1.03. CPAN is 1.08. The source code for Timeline.pm says 2.07. I think it's best to delete my version of work from CPAN's.

@nigelhorne
Copy link
Copy Markdown
Author

FWIW, I'm also playing with visjs to decide which I prefer. There are pros and cons of both it an simile.

@ronsavage
Copy link
Copy Markdown
Owner

ronsavage commented Apr 10, 2017 via email

Copy link
Copy Markdown
Owner

@ronsavage ronsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx Nigel. Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants