Repository navigation
[SDK-803] Resolve open Dependabot alerts in examples, group security updates - #187
Conversation
…updates Bump the example apps past every open advisory in one change: - examples/react-17, examples/typescript: vite ^8.3.5, vitest ^4.1.12 (clears the 16 open vite and @vitest/mocker alerts) - examples/nextjs, examples/nextjs-approuter: next and eslint-config-next 16.4.3, still pinned exactly (critical RCEs GHSA-2464-fhr4-w9xw and GHSA-673q-mjm6-r5xr plus a high DoS, not yet raised as alerts) - all four: refresh zod and undici in the lockfiles Lockfiles regenerated with npm 10, the version CI uses. npm audit reports 0 vulnerabilities in every example. Add .github/dependabot.yml so future security updates are grouped into one PR per directory per ecosystem instead of one PR per package. Routine version updates stay off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI Agent Review LGTM (openai, openai-astra)LGTM. No blocking findings were found. Bumps Verified in the checkout
Notes (not findings)
|
Review feedback: use the most frequent schedule available. The named intervals stop at `daily`, which only runs on weekdays, so both ecosystems now use `interval: cron` with `cronjob: '0 * * * *'`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependabot's config check rejected '0 * * * *' because cron schedules must be at least 24 hours apart. '0 0 * * *' is the most frequent valid schedule. Unlike `interval: daily`, it also runs on weekends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI Agent Review LGTM (openai, openai-astra)LGTM. No blocking findings were found. No findings. The manifest bumps and lockfile refreshes are consistent, and no vulnerable versions remain in the four examples. What I checked
Not verified (depends on GitHub's service, not this repo)
Declared in the description, not verified
|
pacoesteban
left a comment
There was a problem hiding this comment.
LGTM. Resolved versions in all four lockfiles match the manifests (next 16.4.3, vite 8.3.5, vitest and @vitest/mocker 4.1.12, undici 7.30.1, zod 4.6.7), the two Next.js RCE advisories are patched from 16.4.1, and the .yalc entries now match the root package.json. The four remaining react-router alerts are stale graph data: react-17 no longer pulls react-router and typescript is on 7.18.4.
Description of the change
Resolves every open Dependabot alert on the repo in one PR, and also fixes advisories that GitHub's dependency graph hasn't raised as alerts yet. All the vulnerable packages are dev/example dependencies. Nothing changes in the published
@rollbar/reactpackage or the root lockfile.Version bumps (option A from the SDK-803 plan)
react-17,typescriptvite^8.3.0→^8.3.5,vitest^4.1.11→^4.1.12@vitest/mockeralerts (#767–#770)nextjs,nextjs-approuternextandeslint-config-next16.3.8→16.4.3, still pinned exactlyzod(→ 4.6.7)eslint-plugin-react-hooksreact-17,typescriptundici(→ 7.30.1)jsdom. The Next.js examples usejsdom20 and don't lockundiciNo major-version bumps and no peer conflicts. The other lockfile changes are transitive patch/minor updates: rolldown,
@vitest/*, postcss, chai and nanoid. The.yalc/@rollbar/reactentry in the two Next.js lockfiles is now in sync with the current package manifest. It had been stale since prop-types moved todependencies(#178).The 4 react-router alerts (#626, #627, #633, #719) were fixed on
mainby #173 (react-17 no longer uses react-router, and typescript is on 7.18.4). GitHub's dependency graph still lists 6.30.6. This PR rewrites both of those lockfiles, which should make GitHub rebuild the graph and close them. If they're still open after merge, they can be dismissed as "inaccurate"..github/dependabot.yml(option D): the repo had no Dependabot config, so each advisory arrived as one PR per package per example. Those PRs touch the same lockfiles and conflict with each other (e.g. #183 and #185). The new config:npmin/and/examples/*, plusgithub-actionsapplies-to: security-updates), so it's one PR per directory instead of one per packageopen-pull-requests-limit: 0, which doesn't affect security updates)cron(0 0 * * *), per review. Dependabot rejects cron expressions that fire more often than every 24 hours, andinterval: dailyskips weekends. The schedule only affects version updates. Security updates are raised when an alert opens.Supersedes Dependabot PRs #182, #183 and #185, which can be closed once this merges.
How this was validated
On Node 20.19 / npm 10.9 (the CI floor), from a clean install, in the same order as
ci.yaml:npm run install:all -- ci✅npm run lint -- --max-warnings 0✅.prettier --checkpasses on every changed file (the 13 files it flags were already flagged onmain).npm run lint:examples✅npm run typecheck✅npm run build:all✅ (Next.js 16.4.3 builds both Next examples, and vite 8.3.5 builds react-17 and typescript)npm run test✅ (13 tests) andnpm run test:examples✅npm auditin each example: 0 vulnerabilities in all fourCI covers Node 22 and 24.
Type of change
Related issues
🤖 Generated with Claude Code