fix(logback): restrict recursive logger suppression to Rollbar package#376
Open
Montana wants to merge 4 commits into
Open
fix(logback): restrict recursive logger suppression to Rollbar package#376Montana wants to merge 4 commits into
Montana wants to merge 4 commits into
Conversation
Montana
commented
Jun 5, 2026
Author
There was a problem hiding this comment.
Cleaned up the implementation and removed the accidental extra formatting changes so the final diff is focused only on the recursive logger suppression fix.
The branch now includes a few incremental cleanup commits from editing through the GitHub interface, but the resulting code is in the intended state. The maintainer can squash the commits during merge to keep the history clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only suppress events emitted by the
com.rollbarlogger or one of its package descendants.The previous recursive logging check used a broad prefix match against
com.rollbar. As a result, unrelated application loggers with names that happened to begin with the same characters were incorrectly treated as internal Rollbar loggers and silently skipped. For example, a logger such ascom.rollbarista.checkoutwould never be forwarded to Rollbar even though it is not part of the Rollbar package.So this updates the check so it only matches the exact
com.rollbarlogger or names beginning with thecom.rollbar.package boundary. This preserves the recursive logging protection for Rollbar’s own internal logs while allowing similarly named application packages to be reported normally.