Component statement support for <children> and field attributes#971
Open
iObject wants to merge 28 commits intoin-code-componentfrom
Open
Component statement support for <children> and field attributes#971iObject wants to merge 28 commits intoin-code-componentfrom
<children> and field attributes#971iObject wants to merge 28 commits intoin-code-componentfrom
Conversation
TwitchBronBron
requested changes
Nov 30, 2023
Member
TwitchBronBron
left a comment
There was a problem hiding this comment.
Looks pretty good!
I'd like to see some unit tests to verify these features work and ensure they continue to work in the future. You can add them in ComponentStatement.spec.ts and follow this existing test's model:
brighterscript/src/parser/tests/statement/ComponentStatement.spec.ts
Lines 327 to 348 in 086e267
Let's add at least one for each annotation type, but feel free to do more with variations on the annotation (like what happens if the annotation is present but missing the string for example). Maybe test a few with several annotations present at the same time, that type of thing.
You run them by calling npm run test:nocover or by using the test task in vscode.
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
iObject
commented
Nov 30, 2023
<children> and field attributes
…/github.com/rokucommunity/brighterscript into add-component-children-and-field-attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.