Add test suite, find bugs, fix bug, add feature PATCH /tasks/:id/assign - #87
Open
kartikrautan wants to merge 1 commit into
Open
Add test suite, find bugs, fix bug, add feature PATCH /tasks/:id/assign#87kartikrautan wants to merge 1 commit into
kartikrautan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(page - 1) * limit)Test results
Coverage
What you'd test next if you had more time:
Add concurrency/race condition tests (multiple requests updating same task), performance/load testing with large datasets, and error handling for malformed JSON payloads.
Anything that surprised you in the codebase:
No database layer (all in-memory storage resets on restart) and no authentication/authorization checks means the API trusts all clients completely — would be a security concern in production.
Any questions you'd ask before shipping this to production:
Should completed tasks be modifiable? Should we add soft-delete instead of hard-delete? Do we need to persist data to a real database? Should there be role-based access control for assigning tasks?