Take-Home Assignment Submission - Shivam Verma - #80
Open
shivamvermajss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take-Home Assignment Submission
Implemented the requested testing, bug investigation, bug fix, and API feature work.
Completed
BUG_REPORT.mddocumenting discovered bugsgetPaginated()PATCH /tasks/:id/assignSelected Bug Fix
Fixed the pagination offset calculation from:
page * limitto:
(page - 1) * limitThis makes pagination behave correctly for 1-indexed pages.
Test Status
56 tests are currently passing.
3 tests remain failing for bugs that were discovered and documented in
BUG_REPORT.mdbut were intentionally not selected for the Part B fix.Branch
shivam-assignment