Take-Home Assignment Submission –> Pritul Singh - #79
Open
pritulsingh wants to merge 3 commits into
Open
Conversation
fix: correct pagination and task completion behavior test: improve task route and service coverage docs: add bug report and submission notes
pritulsingh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two existing bugs identified through testing and adds task assignment functionality.
Changes
Bug Fixes
page=1correctly returns the first page of tasks.medium.Task Assignment
PATCH /tasks/:id/assignendpoint.assignTask()to the task service.assigneefield.Tests
Added unit and integration tests covering:
Documentation
BUGS.mddocumenting the discovered bugs, causes, and fixes.SUBMISSION.mdwith additional testing considerations and production questions.Notes
The existing behaviors around partial status matching, unvalidated status query parameters, and
page=0handling were documented but intentionally left unchanged as they were considered outside the scope of this pass.