Bugfix and assign endpoint - #76
Open
HeenaShaikh09 wants to merge 3 commits into
Open
Conversation
…dd PATCH /tasks/:id/assign endpoint with tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Notes
What I'd test next if I had more time:
Load/stress testing the pagination endpoint now that the offset bug is fixed. I'd also add tests for edge cases like
limit=0, negative page numbers, and non-numericpage/limitquery values.What surprised me in the codebase:
The
completeTaskbug was the most interesting one — a deliberate-looking line (priority: 'medium') that silently overwrote a task's real priority every time it was marked done. Easy to miss just reading the code, but obvious once tested.Questions I'd ask before shipping to production:
completeTaskpriority reset intentional, or a bug?getByStatusvalidate against the status enum instead of substring-matching?GET /tasks/:idroute needed before shipping?