Add tests (97% coverage), fix pagination bug, document 5 remaining bugs, implement /assign endpointFeature/tests bugfix assign - #68
Open
tusharsach16 wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added unit and integration tests for the Task Manager API, identified and documented 6 bugs, fixed one, and implemented the
PATCH /tasks/:id/assignendpoint.Tests
taskService.jsdirectlyBug Fixed
Pagination off-by-one (
taskService.js:12):getPaginatedcalculated the offset aspage * limitinstead of(page - 1) * limit, causing page 1 to skip all its results. One-line fix.Bugs Documented (BUGS.md)
5 additional bugs identified and documented with expected/actual behavior, root cause, and proposed fix:
getByStatususes.includes()instead of===— partial strings like"do"match both"todo"and"done"completeTask()hardcodespriority: 'medium', overwriting the task's original priorityif (body.status)) — empty string""bypasses enum validationGET /taskshas mutually exclusive branches for status filtering and pagination — combining both ignores paginationupdate()spreads all client fields without strippingidorcreatedAt— a PUT request can overwrite internal metadataNew Endpoint
PATCH /tasks/:id/assign— assigns a user to a task.{ "assignee": "string" }(required, non-empty)validateAssignTask(), consistent with existing validator patternassignee: nulladded tocreate()for consistent task shape