Repository navigation
feat: implement bulk deletion for tables with composite primary keys - #1896
Merged
Merged
Conversation
- Added end-to-end tests for bulk deletion of rows in PostgreSQL, handling cases where the number of keys exceeds statement limits and ensuring proper logging of deletions. - Introduced unit tests for primary key normalization and filtering, ensuring correct handling of composite keys and null values. - Refactored data access objects for ClickHouse, MSSQL, MySQL, Oracle, and PostgreSQL to utilize new bulk primary key handling logic, improving efficiency and correctness in bulk delete operations. - Created helper functions for normalizing primary keys, chunking them according to database limits, and applying filters in queries. - Updated error messages for clarity regarding primary key requirements.
Artuomka
enabled auto-merge
October 14, 2026 11:48
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 22
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
0,false, andnullare preserved during row lookup, updates, and deletion. Invalid or inconsistent primary-key fields are rejected.