Skip to content

feat: migrate chart-edit config to Formly dynamic forms #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gugu wants to merge 2 commits into from
Closed

feat: migrate chart-edit config to Formly dynamic forms #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c815906
feat: migrate chart-edit config to Formly dynamic forms
gugu Mar 9, 2026
f1a584d
fix: resolve reactivity bugs and simplify formly chart config
gugu Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
"@jsonurl/jsonurl": "^1.1.8",
"@material-symbols/font-400": "^0.40.2",
"@ngstack/code-editor": "^9.0.0",
"@ngx-formly/core": "^7.1.0",
"@ngx-formly/material": "^7.1.0",
"@sentry-internal/rrweb": "^2.31.0",
"@sentry/angular": "^10.33.0",
"@stripe/stripe-js": "^5.3.0",
Expand Down
353 changes: 89 additions & 264 deletions frontend/src/app/components/charts/chart-edit/chart-edit.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,17 +308,104 @@
height: 100%;
}

.chart-config {
/* Formly layout classes */
:host ::ng-deep .chart-config {
display: flex;
gap: 16px;
flex-wrap: wrap;
}

.chart-config-field {
:host ::ng-deep .chart-config-field {
flex: 1;
min-width: 150px;
}

:host ::ng-deep .series-section {
display: flex;
flex-direction: column;
gap: 12px;
margin-top: 8px;
}

:host ::ng-deep .series-fields {
display: flex;
gap: 12px;
flex-wrap: wrap;
}

:host ::ng-deep .series-fields-group {
display: flex;
flex-direction: column;
gap: 4px;
}

:host ::ng-deep .series-field {
flex: 1;
min-width: 120px;
}

:host ::ng-deep .series-field--small {
max-width: 100px;
min-width: 80px;
}

:host ::ng-deep .series-options {
display: flex;
gap: 16px;
align-items: center;
flex-wrap: wrap;
margin-top: 4px;
}

:host ::ng-deep .series-mode-field {
min-width: 160px;
font-size: 13px;
}

:host ::ng-deep .series-column-config {
display: flex;
gap: 12px;
flex-wrap: wrap;
}

:host ::ng-deep .option-group {
display: flex;
flex-direction: column;
gap: 12px;
padding: 4px 0;
}

:host ::ng-deep .option-field {
min-width: 120px;
}

:host ::ng-deep .inline-fields {
display: flex;
gap: 12px;
flex-wrap: wrap;
}

:host ::ng-deep .inline-fields .option-field {
flex: 1;
}

:host ::ng-deep .axis-label {
margin: 8px 0 0;
font-size: 13px;
font-weight: 500;
color: rgba(0, 0, 0, 0.6);
}

@media (prefers-color-scheme: dark) {
:host ::ng-deep .axis-label {
color: rgba(255, 255, 255, 0.6);
}
}

:host ::ng-deep .advanced-options {
margin-top: 8px;
}

.chart-container {
min-height: 250px;
padding: 16px;
Expand Down Expand Up @@ -433,265 +520,3 @@
vertical-align: middle;
margin-right: 4px;
}

/* Series section */
.series-section {
display: flex;
flex-direction: column;
gap: 12px;
margin-top: 8px;
}

.series-section .section-header h4 {
margin: 0;
font-size: 14px;
font-weight: 500;
}

.add-series-button {
font-size: 13px;
}

.add-series-button mat-icon {
font-size: 18px;
width: 18px;
height: 18px;
}

.series-card {
border: 1px solid rgba(0, 0, 0, 0.12);
border-radius: 4px;
padding: 12px;
}

@media (prefers-color-scheme: dark) {
.series-card {
border-color: rgba(255, 255, 255, 0.12);
}
}

.series-card-header {
display: flex;
align-items: center;
justify-content: space-between;
margin-bottom: 8px;
}

.series-number {
font-size: 12px;
font-weight: 500;
text-transform: uppercase;
color: rgba(0, 0, 0, 0.54);
}

@media (prefers-color-scheme: dark) {
.series-number {
color: rgba(255, 255, 255, 0.54);
}
}

.remove-series-button {
width: 28px !important;
height: 28px !important;
line-height: 28px !important;
}

.remove-series-button mat-icon {
font-size: 16px;
width: 16px;
height: 16px;
}

.series-fields {
display: flex;
gap: 12px;
flex-wrap: wrap;
}

.series-field {
flex: 1;
min-width: 120px;
}

/* Color picker */
.series-color-picker {
display: flex;
flex-direction: column;
gap: 4px;
min-width: 80px;
}

.color-picker-label {
font-size: 12px;
color: rgba(0, 0, 0, 0.6);
}

@media (prefers-color-scheme: dark) {
.color-picker-label {
color: rgba(255, 255, 255, 0.6);
}
}

.color-picker-row {
display: flex;
align-items: center;
gap: 6px;
}

.color-input {
width: 36px;
height: 36px;
padding: 2px;
border: 1px solid rgba(0, 0, 0, 0.12);
border-radius: 4px;
cursor: pointer;
background: none;
}

@media (prefers-color-scheme: dark) {
.color-input {
border-color: rgba(255, 255, 255, 0.12);
}
}

.color-input::-webkit-color-swatch-wrapper {
padding: 2px;
}

.color-input::-webkit-color-swatch {
border: none;
border-radius: 2px;
}

.color-input::-moz-color-swatch {
border: none;
border-radius: 2px;
}

.color-reset-button {
width: 24px !important;
height: 24px !important;
line-height: 24px !important;
}

.color-reset-button mat-icon {
font-size: 14px;
width: 14px;
height: 14px;
}

.color-auto-label {
font-size: 12px;
color: rgba(0, 0, 0, 0.38);
}

@media (prefers-color-scheme: dark) {
.color-auto-label {
color: rgba(255, 255, 255, 0.38);
}
}

/* Palette colors */
.palette-colors {
display: flex;
flex-wrap: wrap;
gap: 8px;
}

.palette-color-item {
display: flex;
align-items: center;
gap: 2px;
}

.color-remove-button {
width: 24px !important;
height: 24px !important;
line-height: 24px !important;
}

.color-remove-button mat-icon {
font-size: 14px;
width: 14px;
height: 14px;
}

.series-mode-field {
min-width: 160px;
font-size: 13px;
}

.series-column-config {
display: flex;
gap: 12px;
flex-wrap: wrap;
}

.palette-actions {
display: flex;
gap: 8px;
flex-wrap: wrap;
margin-top: 4px;
}

.add-color-button {
font-size: 13px;
}

.add-color-button mat-icon {
font-size: 18px;
width: 18px;
height: 18px;
}

.series-field--small {
max-width: 100px;
min-width: 80px;
}

.series-options {
display: flex;
gap: 16px;
align-items: center;
flex-wrap: wrap;
margin-top: 4px;
}

/* Advanced options accordion */
.advanced-options {
margin-top: 8px;
}

.option-group {
display: flex;
flex-direction: column;
gap: 12px;
padding: 4px 0;
}

.option-field {
min-width: 120px;
}

.inline-fields {
display: flex;
gap: 12px;
flex-wrap: wrap;
}

.inline-fields .option-field {
flex: 1;
}

.axis-label {
margin: 8px 0 0;
font-size: 13px;
font-weight: 500;
color: rgba(0, 0, 0, 0.6);
}

@media (prefers-color-scheme: dark) {
.axis-label {
color: rgba(255, 255, 255, 0.6);
}
}
Loading
Loading