Skip to content

Added ora spinner, help message, info about API key & more!#4

Open
xxczaki wants to merge 3 commits into
roccomuso:masterfrom
xxczaki:master
Open

Added ora spinner, help message, info about API key & more!#4
xxczaki wants to merge 3 commits into
roccomuso:masterfrom
xxczaki:master

Conversation

@xxczaki

@xxczaki xxczaki commented Jan 29, 2018

Copy link
Copy Markdown

Changelog:

Everything is working! (You need to provide your own API key of course, but it's free now 😄).

@roccomuso

Copy link
Copy Markdown
Owner

Thanks ;) I'm gonna review it

@sg-s

sg-s commented Oct 15, 2018

Copy link
Copy Markdown

bump

@roccomuso

Copy link
Copy Markdown
Owner

@xxczaki did you see the review request? once that is addresses I can merge

@xxczaki

xxczaki commented Oct 17, 2018

Copy link
Copy Markdown
Author

@roccomuso no, where is it?

@roccomuso

Copy link
Copy Markdown
Owner

Above

The API KEY cannot be hardcoded. We could add a new param to register a key and store in a .imdb-cli file located in $HOME like npm does.

@Kabouik

Kabouik commented Aug 23, 2021

Copy link
Copy Markdown

Bump @xxczaki, would love to see that merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants