Replace deprecated react-native deep imports in RNMBXMapView codegen#4133
Closed
mariusud wants to merge 1 commit intornmapbox:mainfrom
Closed
Replace deprecated react-native deep imports in RNMBXMapView codegen#4133mariusud wants to merge 1 commit intornmapbox:mainfrom
mariusud wants to merge 1 commit intornmapbox:mainfrom
Conversation
mariusud
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
mariusud
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
mariusud
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
Contributor
Contributor
|
Closing this as #3992 is a more complete fix. I'm not sure we're going to merge this at this point as this requires rn 0.80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
ReactNativeJS: Deep imports from the 'react-native' package are deprecated ('react-native/Libraries/Utilities/codegenNativeComponent'). Source: maps/src/specs/RNMBXMapViewNativeComponent.ts 2:0Also, use CodegenTypes like here https://github.com/facebook/react-native/blob/0e175ce5b6c80a21237f5cd0f20c9876fa975935/packages/react-native/types/__typetests__/fabric-component-sample.ts#L11
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing