You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Review: fix(frontend): treat undefined input as empty
Summary: This is a correct and minimal fix. When data.input is undefined/falsy, the previous code would call btoa(JSON.stringify(undefined)) which produces "dW5kZWZpbmVk" (base64 of the string "undefined"), sending unexpected data to the API instead of omitting the field.
The Fix is Correct
The change correctly leaves input as undefined when not provided, so the API call omits the field entirely rather than encoding a nonsensical value.
Minor Consideration
The falsy check (data.input ?) would also skip encoding for an empty string "", 0, or false. Since input here is actor initialization data (likely an object or null), this is fine in practice. If the type allows non-object falsy values as valid inputs, data.input != null would be marginally more precise — but given the domain context (actor input payload is a JSON-serializable object), this is a non-issue.
Verdict
LGTM. The change is correct and addresses a real bug where actors without explicit input would receive a garbled base64-encoded "undefined" string instead of omitting the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: