Skip to content

test(execution): keep inline module calls independently evaluated #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanFlurry wants to merge 1 commit into
base: stack/test-execution-cover-context-top-level-await-zznlqovp
Choose a base branch
from
Open

test(execution): keep inline module calls independently evaluated #1955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 55 additions & 2 deletions crates/native-sidecar/tests/language_execution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,9 +692,12 @@ fn javascript_module_execution_accepts_inline_exports_in_a_context() {
wire_vm(&connection_id, &session_id, &vm_id),
wire::RequestPayload::JavaScriptExecutionRequest(wire::JavaScriptExecutionRequest {
process: context_process_options("module-context"),
source: String::from("export const y = 1;"),
source: String::from(
"globalThis.moduleRuns = (globalThis.moduleRuns ?? 0) + 1;\n\
export const y = globalThis.moduleRuns;",
),
format: Some(wire::JavaScriptModuleFormat::Module),
file_path: None,
file_path: Some(String::from("/workspace/reused-inline.mjs")),
inputs: None,
}),
))
Expand All @@ -710,6 +713,56 @@ fn javascript_module_execution_accepts_inline_exports_in_a_context() {
assert_eq!(result.outcome, wire::ExecutionOutcome::Succeeded);
assert_eq!(result.exit_code, Some(0));

let repeated = sidecar
.dispatch_wire_blocking(wire_request(
5,
wire_vm(&connection_id, &session_id, &vm_id),
wire::RequestPayload::JavaScriptExecutionRequest(wire::JavaScriptExecutionRequest {
process: context_process_options("module-context"),
source: String::from(
"globalThis.moduleRuns = (globalThis.moduleRuns ?? 0) + 1;\n\
export const y = globalThis.moduleRuns;",
),
format: Some(wire::JavaScriptModuleFormat::Module),
file_path: Some(String::from("/workspace/reused-inline.mjs")),
inputs: None,
}),
))
.expect("repeat inline ES module with the same identity");
assert_eq!(accepted_execution_id(repeated), execution_id);
let repeated_result = wait_for_execution(
&mut sidecar,
&connection_id,
&session_id,
&vm_id,
&execution_id,
);
assert_eq!(repeated_result.outcome, wire::ExecutionOutcome::Succeeded);

let evaluation = sidecar
.dispatch_wire_blocking(wire_request(
6,
wire_vm(&connection_id, &session_id, &vm_id),
wire::RequestPayload::JavaScriptEvaluationRequest(wire::JavaScriptEvaluationRequest {
process: context_process_options("module-context"),
expression: String::from("globalThis.moduleRuns"),
format: Some(wire::JavaScriptModuleFormat::Module),
file_path: None,
inputs: None,
}),
))
.expect("read repeated module execution count");
assert_eq!(accepted_execution_id(evaluation), execution_id);
let evaluation_result = wait_for_execution(
&mut sidecar,
&connection_id,
&session_id,
&vm_id,
&execution_id,
);
assert_eq!(evaluation_result.outcome, wire::ExecutionOutcome::Succeeded);
assert_eq!(evaluation_result.evaluation_value.as_deref(), Some("2"));

reset_execution(
&mut sidecar,
&connection_id,
Expand Down