fix(native-sidecar): always answer sync-RPC waiters on handler failure#1809
Conversation
Three sites could complete or abandon guest-driven work without ever answering the guest, leaving it blocked until the ~31s bridge deadline: - service.rs: the deferred fd wakes ran with `?` BEFORE response delivery, so a wake failure discarded an already-successful result. The wakes are a side effect for OTHER waiters and must not fail this request. - service.rs: the chmod shadow mirror had the same pre-delivery `?`. - process_events.rs: an internal event is leased (popped) before dispatch, so a handler error destroyed it outright; when it was a sync-RPC request the waiter ceased to exist anywhere. The waiter is now answered with the errno. Answering is preferred over requeueing: a deterministic handler failure would otherwise be retried forever, and the guest is owed the errno rather than silence.
Member
Author
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three sites could complete or abandon guest-driven work without ever
answering the guest, leaving it blocked until the ~31s bridge deadline:
?BEFORE response delivery,so a wake failure discarded an already-successful result. The wakes are a
side effect for OTHER waiters and must not fail this request.
?.so a handler error destroyed it outright; when it was a sync-RPC request
the waiter ceased to exist anywhere. The waiter is now answered with the
errno.
Answering is preferred over requeueing: a deterministic handler failure
would otherwise be retried forever, and the guest is owed the errno rather
than silence.