Skip to content

fix(runtime-core): handle stdin error events in StdioFrameTransport #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanFlurry wants to merge 1 commit into
base: stack/test-load-add-bounded-docker-load-testing-harness-and-issue-ledger-lvwtmyvu
Choose a base branch
from
Open

fix(runtime-core): handle stdin error events in StdioFrameTransport #1805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/runtime-core/src/frame-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,12 @@ export class StdioFrameTransport<TReadFrame, TWriteFrame = TReadFrame>
this.stdout.on("data", this.handleData);
this.stdout.on("end", this.handleEnd);
this.stdout.on("error", this.handleError);
// The write side needs its own error listener. Without it, a failed
// write (e.g. EPIPE when the sidecar process dies) emits an 'error'
// event with no listener, which Node throws as an uncaught exception
// and kills the host process (LT-013). Route it to the transport's
// error listeners so callers see a normal, typed transport error.
this.stdin.on("error", this.handleError);
}

onFrame(handler: (frame: TReadFrame) => void): () => void {
Expand Down Expand Up @@ -262,6 +268,7 @@ export class StdioFrameTransport<TReadFrame, TWriteFrame = TReadFrame>
this.stdout.off("data", this.handleData);
this.stdout.off("end", this.handleEnd);
this.stdout.off("error", this.handleError);
this.stdin.off("error", this.handleError);
this.frameListeners.clear();
this.errorListeners.clear();
this.endListeners.clear();
Expand Down