Skip to content

feat(runtime-core): forward live sidecar stderr via AGENTOS_SIDECAR_STDERR #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanFlurry wants to merge 1 commit into
base: stack/fix-runtime-core-handle-stdin-error-events-in-stdioframetransport-lukwzrzn
Choose a base branch
from
Open

feat(runtime-core): forward live sidecar stderr via AGENTOS_SIDECAR_STDERR #1801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/runtime-core/src/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@ export class StdioSidecarProcess {
private constructor(child: ChildProcessWithoutNullStreams, control: Duplex) {
this.child = child;
this.control = control;
// Buffering sidecar stderr and only replaying it on exit means a LIVE
// sidecar's warnings/errors are invisible to the host — a guest-triggered
// failure that the sidecar survives leaves no host-visible trace at all.
// AGENTOS_SIDECAR_STDERR=1 forwards it to host stderr as it arrives.
const forwardStderr = process.env.AGENTOS_SIDECAR_STDERR === "1";
this.child.stderr.on("data", (chunk: Buffer | string) => {
this.stderrChunks.push(
typeof chunk === "string" ? Buffer.from(chunk) : Buffer.from(chunk),
);
const buffer =
typeof chunk === "string" ? Buffer.from(chunk) : Buffer.from(chunk);
this.stderrChunks.push(buffer);
if (forwardStderr) process.stderr.write(buffer);
});
this.child.on("exit", (code, signal) => {
const error = new SidecarProcessExited({
Expand Down