Open
Conversation
bgentry
force-pushed
the
bg/jobs-link-active-fix
branch
from
1df1c20 to
a857cde
Compare
The jobs state sidebar could show `Running` as active even when another state was selected. This happened because the jobs route strips the default `state=running` from search params, so the running link was matching too broadly. The filter links now require exact + search-aware active matching and preserve non-state search params while setting `state`. This makes the active indicator follow the selected job state correctly. A regression test uses the same jobs search middleware behavior and asserts that only the selected state is active while `Running` is active for the default `/jobs` state. Fixes #526
bgentry
force-pushed
the
bg/jobs-link-active-fix
branch
from
a857cde to
d10e7a2
Compare
Contributor
Author
|
I confirmed with manual testing that this fixes the issue 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jobs state sidebar could show
Runningas active even when another state was selected. This happened because the jobs route strips the defaultstate=runningfrom search params, so the running link was matching too broadly.The filter links now require exact + search-aware active matching and preserve non-state search params while setting
state. This makes the active indicator follow the selected job state correctly.A regression test uses the same jobs search middleware behavior and asserts that only the selected state is active while
Runningis active for the default/jobsstate.Fixes #526