Repository navigation
[rust] Align CLI with Go reference implementation - #1580
Merged
Merged
Conversation
brandur
force-pushed
the
codex/rust-cli-migration-output
branch
from
November 4, 2026 14:21
ca44d02 to
bdb9b35
Compare
bgentry
approved these changes
Nov 4, 2026
|
|
||
| ### Fixed | ||
|
|
||
| - Align migration CLI output with Go: `migrate-list` shows every bundled version and name, marking the latest applied version with `*`; migration progress uses the Go format and reports when nothing remains to apply; successful validation is silent. SQL output now requires `--show-sql`, including with `--dry-run`. [PR #XXX](https://github.com/riverqueue/river/pull/XXX). |
This came up in #506, but it turns out that Rust's CLI behaves different with respect to migration output compared to the reference implementation in Go. Here, tighten that up so that: * `migrate-list` shows all versions and names, marking the latest applied with `*`. * Progress output follows Go’s format; successful validation is silent. * SQL output requires `--show-sql`, including during dry runs.
brandur
force-pushed
the
codex/rust-cli-migration-output
branch
from
November 4, 2026 14:36
bdb9b35 to
6a2fa85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in #506, but it turns out that Rust's CLI behaves different
with respect to migration output compared to the reference implementation
in Go.
Here, tighten that up so that:
migrate-listshows all versions and names, marking the latestapplied with
*.--show-sql, including during dry runs.