[RaphaelFakhri]

JobListParams.Where accepts several sets of named arguments and merges them, with later sets overwriting earlier ones. It merged them by copying every later set into the first map the caller passed, so that map gained or changed keys:

base := river.NamedArgs{"queue": "default"}
params := river.NewJobListParams().Where("queue = @queue AND kind = @kind", base, river.NamedArgs{"kind": "email"})
// base is now {"queue": "default", "kind": "email"}

Reusing base in another Where then sends kind to a query that doesn't reference @kind, and JobList fails with expected "..." to contain named arg symbol @kind. The stored predicate also aliased the caller's map, so later edits to it changed params that were already built. Passing nil as the first set panicked with assignment to entry in nil map.

This change merges into a new map, the way JobDeleteManyParams.Where already does since #1570.

Changes

• job_list_params.go: merge named arguments into a fresh map in JobListParams.Where.
• job_list_params_test.go: add TestJobListParams_Where, mirroring TestJobDeleteManyParams_Where, covering the merge result, unmodified inputs, and a nil first set.
• CHANGELOG.md: add an entry under Unreleased.

Testing

go test -count=1 -run 'TestJobListParams_Where' -v .

Without the fix, both subtests fail: MergesNamedArgsWithoutMutatingThem reports the first map changed to {"a":1, "b":3}, and NilFirstNamedArgs panics with assignment to entry in nil map. With the fix, both pass. golangci-lint run . (v2.14.0) reports 0 issues.

[brandur]

Hey Raphael! Could you sign our CLA please? https://github.com/riverqueue/rivercla

[RaphaelFakhri]

Signed: riverqueue/rivercla#44 adds me to the signees list.