Ignore TLS error when closing listener from the notifier#1216
Merged
Conversation
Here, address a request coming from #256 in which it's fairly common to see an like this one going to the error logs: > `tls: failed to send closeNotify alert (but connection was closed anyway): write tcp 10.0.5.131:40192->10.0.7.96:5432: i/o timeout` If you read the error message carefully, it indicates that this really isn't a problem. The connection is closed already, and the TLS package just wasn't able to close it as cleanly as it wanted to. Here, modify the site that calls listener close in the notifier so that it ignores these types of errors, thereby cleaning up peoples' error logs somewhat. Fixes #256.
brandur
force-pushed
the
brandur-ignore-listener-close
branch
from
c101cb1 to
1d54fe1
Compare
bgentry
approved these changes
Apr 18, 2026
Contributor
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
Looks good and definitely worth trying, thanks!
Contributor
Author
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, address a request coming from #256 in which it's fairly common to
see an like this one going to the error logs:
If you read the error message carefully, it indicates that this really
isn't a problem. The connection is closed already, and the TLS package
just wasn't able to close it as cleanly as it wanted to.
Here, modify the site that calls listener close in the notifier so that
it ignores these types of errors, thereby cleaning up peoples' error
logs somewhat.
Fixes #256.