Shader Minifier Mesa Bugfix#108
Open
yasirtug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, while compiling shaders, Mesa on some platforms rejects expressions like this:
void fn(OUT(vec2)A)while accepting
void fn(OUT(vec2) A)This change fixes that by adding a blank space there. The matching might be too broad, but I couldn't find any tests regarding minification, so I am not aware of any cases this might break things. In my experience, all previously rejected shaders are compiled successfully after this fix.
This is discovered with the help of AI tools.