feat: experimental iOS API support (getEnums via SPM) #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return Promise.async { | ||
| val file = riveFile ?: return@async emptyArray() | ||
| try { | ||
| file.enums.map { enum -> |
Contributor
There was a problem hiding this comment.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
mfazekas
force-pushed
the
feat/rive-ios-experimental
branch
from
491c96b to
95816cf
Compare
Add RiveFile.getEnums() to retrieve enum definitions from Rive files. iOS uses the new experimental API (RiveRuntime 6.15.0 via SPM), Android uses existing File.enums property. Conditional compilation ensures it builds with both SPM and CocoaPods. Set USE_RIVE_SPM=1 with pod install to enable.
mfazekas
force-pushed
the
feat/rive-ios-experimental
branch
from
95816cf to
4fe9e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RiveFile.getEnums()using the new@_spi(RiveExperimental)API on iOSFile.enumsproperty#if RIVE_EXPERIMENTAL_API) ensures backward compatibility with CocoaPodsUsage
Without the flag,
getEnums()throws "not implemented".