Skip to content

tests: Make alert delivery transitions retry-safe#9737

Closed
nishantmonu51 wants to merge 1 commit into
mainfrom
nishant/test-audit-alert-transitions
Closed

tests: Make alert delivery transitions retry-safe#9737
nishantmonu51 wants to merge 1 commit into
mainfrom
nishant/test-audit-alert-transitions

Conversation

@nishantmonu51

Copy link
Copy Markdown
Collaborator

Make alert execution and notification transitions explicit across failures and cancellation.

  • persist resolver and metadata failures in execution history
  • retry notifier failures only when no external delivery succeeded
  • prevent successful notifier deliveries from being duplicated after partial failure
  • distinguish cancellation before delivery from interruption after delivery
  • cover renotify boundaries, malformed persisted state, schedule limits, and URL validation
  • select the newest valid alert warning history entry

Validation:

  • go test -short -race -count=1 -timeout=10m ./runtime/reconcilers -run '^Test(Alert|CalculateAlert|LatestAlert|PrepareAlert|SendAlert|AddExecutionTime)'

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. No documentation update is required.
  • Intend to cherry-pick into the release branch
  • I am proud of this work!

@nishantmonu51 nishantmonu51 added the tests Changes to tests and test infrastructure label Jul 23, 2026
@nishantmonu51 nishantmonu51 changed the title Make alert delivery transitions retry-safe tests: Make alert delivery transitions retry-safe Jul 23, 2026
@nishantmonu51

Copy link
Copy Markdown
Collaborator Author

Temporarily closing to keep the first review wave focused. We will reopen this PR after #9730, #9731, and #9732 have merged. The branch is being retained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Changes to tests and test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant