fix: #521: exclude isa dead qubits from quilc ISA #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BatmanAoD
force-pushed
the
521-quilc-exclude-isa-dead-qubits
branch
from
7a1d57a to
3540e36
Compare
|
BatmanAoD
force-pushed
the
521-quilc-exclude-isa-dead-qubits
branch
from
3540e36 to
12b4ee5
Compare
kalzoo
requested changes
Dec 27, 2024
Contributor
kalzoo
left a comment
kalzoo
left a comment
There was a problem hiding this comment.
Looking good so far - please address that comment and add test coverage for it then we're 👍
Comment on lines
69
to
73
| let edges = edges | ||
| .into_iter() | ||
| .map(|(k, v)| (k.to_string(), v)) | ||
| .filter(|(_, e)| e.has_valid_operations()) | ||
| .collect(); |
Contributor
There was a problem hiding this comment.
To get ahead of a related error - should only be those edges for which both qubits are also included
BatmanAoD
force-pushed
the
521-quilc-exclude-isa-dead-qubits
branch
from
9f59ab3 to
d7d26e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the "dead qubits" part of #521.
Does not fallback from sim-RB to iso benchmark.