Repository navigation
feat(site): add favicon.ico, PNG icons and apple-touch-icon - #139
Merged
Merged
Conversation
The site only declared an SVG icon. /favicon.ico returned 404, and there was no raster fallback or touch icon. This renders the existing assets/logo.svg as: - favicon.ico (16/32/48) - PNG icons (48/96/192/512) - apple-touch-icon.png (180) The two root files are now published, and every page head links them. Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
rig-c.org only declared
/assets/logo.svgas its icon./favicon.icoreturned 404, and the site had no raster fallback or touch icon.Change
assets/logo.svginto these files. No new artwork.favicon.ico(16/32/48)apple-touch-icon.png(180)assets/favicon-48.pngassets/favicon-96.pngassets/icon-192.pngassets/icon-512.pngbuild.ts:<link rel="icon">(ico, svg, 96px png) andapple-touch-iconto every page head.build.test.ts: the missing-asset verification case now also covers the new files.Verification
bun test src: 77 pass, 0 fail🤖 Generated with Claude Code