Repository navigation
fix(examples): re-encode the Family preview from examples 13cfd38 - #138
Merged
Merged
Conversation
The recorded preview on the Examples page was encoded from examples c239b09. Since then examples #98 (1334da1) closed up the lineup and drew two arms at their own depth, and #100 (13cfd38) fixed the overlap order between neighbours. Both touched only family/docs/family-preview* and the render recipe, not the rigs. The family-preview row now pins 13cfd38. At that commit, family-preview.json still gives 67 frames, 3.333 s and 960x832, so fps and frame count are unchanged. encode-video.sh family-preview exits 0: 67 frames, 3.333333 s, 955090 bytes, loop seam 0.914 vs max step 1.197 (PASS). The poster and frame 33 were compared side by side against the old encode. The live demo's FAMILY_SHA stays at c239b09. The Play page's swing build is pinned there, and neither #98 nor #100 changed a model. Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137.
The Examples page's recorded preview was encoded from examples c239b09. Examples #98 (1334da1) closed up the lineup and drew two arms at their own depth, and #100 (13cfd38) fixed neighbour overlap order. Both changed only the preview files and the render recipe; the rigs are untouched.
EXAMPLES=… scripts/encode-video.sh family-previewscripts/loop-seam.py)bun testbun run buildOut of scope: the live demo's
FAMILY_SHAstays at c239b09. The Play page's swing build is pinned there, and neither #98 nor #100 changed a model.🤖 Generated with Claude Code