Repository navigation
fix(family): Roa's hand only, Jinni's legs behind Luna, Jinni's skirt over Naru - #100
Merged
Merged
Conversation
… over Naru Owner review of the #98 previews: Roa's forearm across Luna's neck read as bending it; Jinni's legs crossed over Luna's; Jinni's skirt belongs in front of Naru. Three layer changes, all measured by measure-preview-overlaps.py: - roa-hand-over-luna: Roa's arm is drawn over Luna's body only (Luna's hair, face and neck slots excluded) and only left of Luna's front hair (column 393 in every outfit). Luna's throat is painted into topwear, so the slot exclusion alone left the forearm over her throat. - jinni-legs-behind-luna: Luna drawn over Jinni below the skirt's hem (office 650, uniform 618) or, where legs are painted into bottomwear, where the arm's path ends (homewear 500) and in the gap below the sarong's edge (swimwear 670). - jinni-skirt-over-naru: Jinni drawn over Naru inside her bottomwear's overlap with Naru. Rejected: stopping the hand at Luna's face column (431). It cut the forearm with a visible vertical edge over Luna's collar. Stopping at her front hair hides the forearm behind a painted edge. Verification: PREVIEW_LOOP_PASS on all four outfits; render-readme-preview tests 5/5; render-outfit-switch exit 0. Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99.
Review of the #98 previews found three problems: Roa's forearm across Luna's neck looked like it was bending it, Jinni's legs crossed over Luna's, and Jinni's skirt belongs in front of Naru. Each fix is a measured layer in
family/scripts/preview-overlaps.json, written bymeasure-preview-overlaps.py:roa-hand-over-lunahair_front(column 393); office arm rows 0–400jinni-arm-behind-lunajinni-legs-behind-lunajinni-skirt-over-narubottomwear∩ NaruMeasured overlap pixels per outfit (union over all 101 frames; "rest" = most pixels of the top character, outside its layer slots, that fall inside the path on any one frame):
Leg rows: office and uniform cut at the skirt's hem. Homewear's legs are painted into
bottomwear, so its cut starts where the arm's path ends. Swimwear's cut sits in the gap below the sarong's edge.Rejected
facecolumn (431). Luna's throat is painted intotopwear, so the forearm stayed over her throat and ended in a visible vertical cut over her collar. Stopping at her front hair hides the forearm behind a painted edge.Verification
node --test family/scripts/render-readme-preview.test.mjsrender-readme-preview.mjs× 4 outfitsPREVIEW_LOOP_PASSon eachrender-outfit-switch🤖 Generated with Claude Code