Skip to content

fix: align lockstep pins and parts review compatibility - #381

Merged
firejune merged 1 commit into
mainfrom
jinni/380-review-source-integration
Nov 9, 2026
Merged

firejune merged 1 commit into
mainfrom
jinni/380-review-source-integration

Conversation

@firejune

@firejune firejune commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Create can consume the integrated parts screen through the sibling source workspace once its internal dependencies match the lockstep version. This change pins core, parts and Review to exactly 3.7.0, accepts stable Parts enumerators from 2.25.0 through major 3, completes the synthetic source-link fixture with Play, and regenerates the governed example cohort through its scripts.

The source-link fixture uses a synthetic Play source-entry wrapper to prove link resolution and child condition propagation. Actual sibling source runtime and the real consumer job are post-merge gates. Published Play custom-condition packaging is tracked in rig-c/play#259.

Closes #380

Validation

Command or receipt Exit Result
Initial focused pin/guide/captions tests 1 Preserved RED, 59 pass / 1 skip / 2 fail from incomplete source linking
Typecheck and lint 0 No diagnostics
Nova governed regeneration and all 14 generator checks 0 82.49 seconds, 104 changed artifact hashes independently verified
Direction fixture hash check 0 32 recorded hashes match
Filled chain example check 0 0 refusals / 0 warnings
Seven focused example, pin, guide, caption and compatibility suites on Nova 0 120 pass / 1 skip / 0 fail
Local example and act regression suites 0 29 pass / 0 fail
git grep -n "<3.0.0" HEAD 1 0 output lines, obsolete range absent throughout the tracked repository

Nova receipt 20261109T224224Z-0712f54e49814459a24ddbd79ca51f5e records status passed, exit 0 and process quiescence. The retained negative controls reject Parts 2.24.x, 4.0.0 and prereleases while preserving major-2 acceptance. PR CI remains acceptance. The external workspace configuration is outside this repository and has been prepared without installing or opening an owner job.

Use exact 3.7.0 dependencies for registry installs and sibling source linking. Accept stable Parts enumerators from 2.25 through major 3, retain negative controls, complete source-condition fixtures with Play, and regenerate the governed examples through their writers.

Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com>
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T22:51:55.413886Z d3daa41 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@firejune firejune added the by:codex Written by a Codex (Naru) worker; Claude side judges the review label Nov 9, 2026
@firejune

firejune commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Claude review (cross-family)

Head reviewed: d3daa41548a2157acc702d885fd6bf1a7cd6136b

Files read:

  • src/review-act.ts
  • src/pins.ts
  • package.json
  • scripts/generate-example-draft.ts
  • tests/review-act.test.ts
  • tests/pins.test.ts
  • tests/review-280-compat.test.ts

The template cohort was taken from the governed regeneration receipt. I did not read it line by line.

Checks:

  • Enumerator guard. Major 2 still needs minor 25 or higher. Major 3 is accepted. All other majors are refused, including 0, 1 and 4+. The stable-only regex still refuses prereleases.
  • Guard tests. The decode test accepts 2.25.0, 2.36.0, 3.0.0 and 3.7.0. It refuses 2.24.9, 4.0.0, 2.25.0-beta.1, 3.7.0-beta.1 and an absent version. The CLI plant moved from 3.0.0 to 4.0.0, so it is still a negative control.
  • Old range literal. git grep -n "<3.0.0" on this head returns 0 lines across the whole tracked repository.
  • Pins. Core, parts and review are exactly 3.7.0, matching the lockstep cut. PINNED_PACKAGES stays exact-version only.
  • Source-link fixture. Core, parts, play and review are all linked now. The play source entry is a synthetic wrapper, so this PR proves link resolution only. The real sibling-source runtime proof is a post-merge gate. The published play packaging defect is tracked in Published source export condition targets an omitted src entry play#259.

Verdict: LGTM at this exact head. It may land once CI on this head is green. Any further push needs a new sign.

@firejune
firejune merged commit 9425b19 into main Nov 9, 2026
1 check passed
@firejune
firejune deleted the jinni/380-review-source-integration branch November 9, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by:codex Written by a Codex (Naru) worker; Claude side judges the review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin the integrated Review C2–C4 parts screen after its release

1 participant