Repository navigation
fix: align lockstep pins and parts review compatibility - #381
Merged
Merged
Conversation
Use exact 3.7.0 dependencies for registry installs and sibling source linking. Accept stable Parts enumerators from 2.25 through major 3, retain negative controls, complete source-condition fixtures with Play, and regenerate the governed examples through their writers. Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
Claude review (cross-family)Head reviewed: Files read:
The template cohort was taken from the governed regeneration receipt. I did not read it line by line. Checks:
Verdict: LGTM at this exact head. It may land once CI on this head is green. Any further push needs a new sign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create can consume the integrated parts screen through the sibling source workspace once its internal dependencies match the lockstep version. This change pins core, parts and Review to exactly 3.7.0, accepts stable Parts enumerators from 2.25.0 through major 3, completes the synthetic source-link fixture with Play, and regenerates the governed example cohort through its scripts.
The source-link fixture uses a synthetic Play source-entry wrapper to prove link resolution and child condition propagation. Actual sibling source runtime and the real consumer job are post-merge gates. Published Play custom-condition packaging is tracked in rig-c/play#259.
Closes #380
Validation
git grep -n "<3.0.0" HEADNova receipt
20261109T224224Z-0712f54e49814459a24ddbd79ca51f5erecords status passed, exit 0 and process quiescence. The retained negative controls reject Parts 2.24.x, 4.0.0 and prereleases while preserving major-2 acceptance. PR CI remains acceptance. The external workspace configuration is outside this repository and has been prepared without installing or opening an owner job.