Skip to content

fix(workspace): retain source resolution in job children - #376

Merged
firejune merged 1 commit into
mainfrom
naru/375-workspace-declare-core-and-retain-source
Nov 9, 2026
Merged

firejune merged 1 commit into
mainfrom
naru/375-workspace-declare-core-and-retain-source

Conversation

@firejune

@firejune firejune commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Create imports core directly and starts job-runtime subprocesses, which previously lost an explicitly enabled play source condition. Declare the existing core 3.6.0 dependency and forward only @rig-c/source to children, so isolated source-linked consumers resolve consistently. Enable the same condition for TypeScript.

Focused checks passed: typecheck, lint, frozen install, and 54 tests with one existing skip. Synthetic Bun parent/child and CLI job lifecycle controls cover explicit source and default dist modes; a planted failure showed the child falling back to dist before the fix. Private version remains 0.0.0 and generated-project pins/templates are unchanged.

Closes #375

Declare the existing core pin directly and enable TypeScript source conditions.
Forward only the explicit play source condition to job-runtime child commands.

Closes #375

Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com>
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
@firejune firejune added the by:codex Written by a Codex (Naru) worker; Claude side judges the review label Nov 9, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T15:25:00.518863Z 9a21657 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@firejune

firejune commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Claude review (cross-family) for head 9a21657: LGTM

  • The job runtime child launches (open, the synchronous actions, and publishCommittedVersion) all go through jobRuntimeCommand. That function forwards only --conditions=@rig-c/source, in either the = or the two-argument form. It skips values that belong to -e/--eval/--preload and the other value flags, and it stops at --. So an eval string containing the flag cannot turn the condition on. The unit cases cover each of these.
  • @rig-c/core 3.6.0 is now a direct dependency that matches PINNED_PACKAGES, and the lock agrees. The package stays private: true, version 0.0.0, and the templates and pins are unchanged.
  • Non-blocking: a value flag that is missing from EXEC_ARGV_VALUE_FLAGS could have its value read as a flag. The only effect would be turning on the source condition when that value is literally the condition flag, so I am not asking for a change.

@firejune

firejune commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

LGTM #376 at 9a21657.

Independent diff and raw focused evidence reviewed. Current-head CI 42644197244 passed, and the single cross-family review covers this head. Synthetic child source/default resolution is covered; live pilot activation remains outside this change.

@firejune
firejune merged commit b9970d2 into main Nov 9, 2026
1 check passed
@firejune
firejune deleted the naru/375-workspace-declare-core-and-retain-source branch November 9, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by:codex Written by a Codex (Naru) worker; Claude side judges the review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workspace: declare core and retain source condition in job children

1 participant