Repository navigation
fix(workspace): retain source resolution in job children - #376
Merged
Merged
Conversation
Declare the existing core pin directly and enable TypeScript source conditions. Forward only the explicit play source condition to job-runtime child commands. Closes #375 Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
Claude review (cross-family) for head 9a21657: LGTM
|
Contributor
Author
firejune
deleted the
naru/375-workspace-declare-core-and-retain-source
branch
November 9, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create imports core directly and starts job-runtime subprocesses, which previously lost an explicitly enabled play source condition. Declare the existing core 3.6.0 dependency and forward only
@rig-c/sourceto children, so isolated source-linked consumers resolve consistently. Enable the same condition for TypeScript.Focused checks passed: typecheck, lint, frozen install, and 54 tests with one existing skip. Synthetic Bun parent/child and CLI job lifecycle controls cover explicit source and default dist modes; a planted failure showed the child falling back to dist before the fix. Private version remains 0.0.0 and generated-project pins/templates are unchanged.
Closes #375