Repository navigation
fix: pin Review 2.7.1 for occluder handoff consumers - #371
Merged
Merged
Conversation
Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin Review exactly to 2.7.1 so its handoff exports include occluder images and receipt-bound plate directories required by Create's correction and applied-review consumers. Parts stays 2.36.0 and Core stays 3.6.0; no record-mode activation or runtime fix is included.
Closes #368. HQ signed this dependency and its invariant-4 checklist.
Validation: installed separate/overlapping occluder handoffs provide all 9/9 inputs, and the 7/9 omission controls produce the expected consumer refusals. Focused tests have 70 pass, 0 fail; typecheck/lint exit 0; filled example has zero refusals and warnings. Six fast generator checks and 32 direction hashes reproduce on Nova (exit 0, 8.27 seconds). Producer/template identities and generated bytes remain unchanged. Full acceptance is PR CI.
Added old-binding bar: a synthetic APFS fixture opened under Review 2.7.0 accepts the bumped CLI's verdict/signoff ingestion, empty and pending reconciliation, and close, all exit 0. Binding bytes stay fixed until close; close leaves project bytes unchanged. Synthetic setup quality HOLEs remain HOLEs. No live owner project or host was accessed.
Execution receipt note: the Nova command completed in 8.27 seconds with a quiescent process boundary, but its configured timeout was 3,600 seconds rather than the requested 600-second cap. This historical deviation was retained; the run was not repeated or relabelled.
Final integration at current main includes the close-only retirement implementation: Review 2.7.1 focused results are 57 review-package + 4 close + 4 refresh + 4 signal tests passing, with typecheck/lint exit 0. The original pin-only old-binding matrix remains a separate receipt. The obsolete pre-integration CI run was cancelled; acceptance uses the final head.