Repository navigation
fix: refresh review publications after record ingestion - #369
Merged
Merged
Conversation
Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a verdict writer updates project.json, job open reused an old rig/post publication and the owner's subsequent signoff failed JOB_RECORD_MOVED. Refresh the same immutable selector over the current record bytes, then re-ask its declared subjects through the existing durable publication outbox. Matching current heads remain idempotent and stale-source checks remain strict.
Closes #366.
Validation: raw pre-fix flow had 1 pass and 3 failures; new flows pass for parts-review, rig-review and direction-review, including stale source, wrong authority/selector, both acts submitted before ingestion, and failed-publication reconciliation. After integrating current main, refresh/open/signal focused tests have 14 pass, 0 fail; typecheck and lint exit 0. Full acceptance is PR CI. All hosts and acts are synthetic; no live owner job was accessed.