Repository navigation
fix: forward job signals and surface writer ask outcomes - #367
Merged
Merged
Conversation
Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending SIGTERM or SIGINT to job open previously killed its CLI wrapper while leaving the runtime host listening. Forward those signals to the wrapper's own asynchronous child and stop the host after in-flight publication work finishes.
Bound writers also surface refused asks after an acknowledged publication instead of silently returning success. Text mode prints asked/already outcomes; --json preserves its JSON stdout and clean success stderr.
Closes #355.
Validation: synthetic orphan/refusal reproduction initially failed all 3 controls. Final signal/ask tests 4 pass, existing focused job tests 43 pass, typecheck and touched-file lint exit 0. Full acceptance is PR CI. Tests use only their own synthetic hosts.