Repository navigation
Accepts the function providers Amendment - #275
Merged
Merged
Conversation
The ADR-0004 Amendment that re-stamps `functions` on every step and refuses a function_providers list that does not resolve at the entry of every event-carrying door, with its dated edit adding start_child_at/6, merged at proposed; the code it decides shipped in statifier_persistence 0.25.0 (tag v0.25.0, 473bfd3). Each claim was re-read at the tag, which is also main, and each held. The Amendment's status word flips in place from proposed to accepted, and a dated foot Note records the flip, the version, the SHA and what was re-read. No other line is removed. Review: the diff touches only docs/adr/, outside gate.build_paths (lib/ test/ config/ mix.exs mix.lock), so it touches no Elixir code and has no gate to run; committed on review of the diff. No changelog fragment: ADRs are on the changelog.d/README.md "do not" side. Refs: sp-mcfw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips ADR-0004's 2026-10-13 Amendment (decision 3's re-stamp gains
functions, and a list that does not resolve is refused at the entry), with its 2026-10-13 dated edit addingDriver.start_child_at/6, from proposed to accepted.The record
docs/adr/0004-run-lifecycle-executor-seam-and-serialization.md, the 2026-10-13 sp-aa9z Amendment.v0.25.0at473bfd3, published on Hex 2026-10-13 by the release workflow.473bfd3, the tag, which is alsomain: nothing has landed onmainsince the tag.v2.15.0tag (99e7427): thefunctionsfield,put_function_providers/2andnew/2raising on a list that does not resolve,Statifier.Positiondropping and blanking the field,Statifier.Session.start_link/2's{:error, {:function_providers, reason}}, andStatifier.Invoke.Source.resolve/2compilingcontentwith no:function_providers. This package's half: the tripwire and the four-field stamp (step_loaded/8); the entry refusal after the re-entrancy check oncreate/4andstep/5(check_function_providers/1), the error arm and the reason type; every row of the door table in the driver (check_function_providers/2,check_start_providers/1), the per-call override with an explicitnil(function_providers/2), the create carrying the list insideinitialize:(create_opts/2) and the steps taking the driver's list (execution_opts/3); the child created withfunction_providers: niland thatnilreaching every step of the child's drive (create_child/6,advance/6), the child's driver keeping the list for the parent's answer; thestart_child_at/6refusal in its own{:refused, _}shape with no:child, :refusedevent; the named tests infunction_providers_test.exsand the tripwire test inexecutions_test.exs; and the 0.25.0 changelog section.The Amendment's own status word flips in place. Its sentence "this amendment is proposed until it is accepted" stays as written and is met by the dated foot Note, which records the flip, the version, the SHA and what was re-read. The diff removes one line, the status text; every other line is an addition at the foot of the file.
The Amendment's "on every step of that drive" for the child's
nilwas re-read against the driver: the child's create hands its options,function_providers: nilincluded, to the drive loop, and the loop hands the same options to every step.Gate
Docs only: the diff touches only
docs/adr/, outside the gate's build paths, so it touches no Elixir code and has no gate to run (the repo's CLAUDE.md commit row); CI still runs the full gate. No changelog fragment: ADRs are onchangelog.d/README.md's "do not" side.Refs: sp-mcfw