Repository navigation
Formats the quality config with the rest - #190
Merged
Merged
Conversation
.formatter.exs now lists .quality.exs among its inputs, so the gate's Format stage checks the quality config the way it checks mix.exs and .formatter.exs itself. The file was not formatter-clean: mix format drops two blank lines between keyword entries. No word, key, value or threshold in .quality.exs changes; git diff --word-diff shows only the two removed blank lines. Refs: sui-rmkv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: sui-rmkv
What
.formatter.exs: the inputs now name.quality.exsbesidemix.exsand.formatter.exs("{mix,.formatter,.quality}.exs"), so the gate's Format stage checks the quality config..quality.exs: formatted bymix format, which removes two blank lines between keyword entries (one beforecredo:, one beforeprofiles:).git diff --word-diff origin/main -- .quality.exsshows no changed word, andgit diff -w --ignore-blank-linesover the file is empty: no key, value, threshold, stage or comment moves.The bead's acceptance takes its first branch: the quality config joins the formatter inputs and is formatted. That choice was decided by the conductor under a standing consent, 2026-10-10.
Authority
The operator's campaign consent, adopted 2026-10-10, names this change in its gate clause, quoted verbatim but for its internal lane label: "sui's
.quality.exsjoining the formatter inputs (... a format-only change)". Any other change to a guarded gate path stays outside it, and this diff makes none.Evidence that the Format stage now sees the file
With the change applied, putting one of the removed blank lines back into
.quality.exsmakesmix format --check-formattedexit 1; restoring the formatted file (byte-equal to the copy taken first) brings it back to exit 0.Gate
Full
mix qualitygreen on this head: every stage passed, 1,214 of 1,214 tests, 93.7% coverage, attested bymix quality.verify. The skip lines are Diataxis (project-level, opt-in), Gettext and Sobelow (not applicable), as before.No changelog fragment: a quality gate change takes none under
changelog.d/README.md.Review
In-turn review of the diff: one input glob widened by one name, and two blank lines removed by the formatter. No record text in this PR.